workflow that requires a code-review for each fix

Is there an existing workflow that requires a code-review for fixes? Our team is young and we need to insure that all code that is applied to fix bugs gets reviewed before it is integrated into the main repo. I'd like this to be part of the bug flow so that bugs are assigned, fixes are coded, then the issue passes through a code review step, which possibly includes returning it to the open state for further work before it is finally integrated and on to the step where it is verified and finally marked as fixed and closed.
4 comments
notifyreporterto approve fix.   there is one in youtrack workflow download page
0
Please clarify - would you like the new field of type user[1] 'Reviewed by' and the new State value 'Reviewed' to be introduce?
0
I am new to youtrack, so I'm not really certain.

The ideal flow would have an assigned 'Integrator' Role, that could
include 1 or more users.
Once work on a feature/bugfix is completed, then the state should be
something like 'Code Complete' or 'Fixed'. At that point the state
should transition to 'Code Review' where one of the integrators could
review the code and merge it into the mainline.

Having a 'Reviewed by' field would work great, and probably states such
as 'Reviewed' and 'Integrated' would be ideal.

We also have a verification process, so the feature/issue should go
through a 'Verify' step also.

Is there a good documentation on the workflows? I'd like to find out
more about the states flows.

Ed

Dmitry Krasilschikov - YouTrack wrote:

*YouTrack <http://forum.jetbrains.com/forum/YouTrack> * > *workflow
that requires a code-review for each fix
<http://forum.jetbrains.com/thread/YouTrack-1143> * 5:01 am
<http://forum.jetbrains.com/thread/YouTrack-1143?message=YouTrack-1143-2>
Dmitry Krasilschikov
<http://forum.jetbrains.com/user/Dmitry_Krasilschikov>

Please clarify - would you like the new field of type user[1]
'Reviewed by' and the new State value 'Reviewed' to be introduce?

     Ed Henderson <http://forum.jetbrains.com/user/Ed%20Henderson> @
     Aug 18 <http://forum.jetbrains.com/thread/YouTrack-1143>

     Is there an existing workflow that requires a code-review for
     fixes? Our team is young and we need to insure that all code that
     is applied to fix bugs gets reviewed before it is integrated into
     the main repo. I'd like this to be part of the bug flow so that
     bugs are assigned, fixes are coded, then the issue passes through
     a code review step, which possibly includes returning it to the
     open state for further work before it is finally integrated and on
     to the step where it is verified and finally marked as fixed and
     closed.

JetBrains Forum | Build #172 (Jul/18/2013 5:34PM) | Feedback
<http://confluence.jetbrains.net/display/JETF/Feedback>
0
Please add needed fields and values on the project > 'Fields' tab, look the reference for details.

This workflow requires to fill the user[1] field 'Reviewed by' on state transition to 'Reviewed':
rule Require reviewed by 
 
when State.becomes({Reviewed}) { 
  Reviewed by.required("Reviewed by user is required."); 
}
prettyPrint();
More workflow examples you can find in the Workflow Language Quick Reference.
review.zip (1.5KB)
0

Please sign in to leave a comment.